Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: update elastic/mito to version v1.15.0 #40294

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 17, 2024

Proposed commit message

This brings error-handling improvements.

  • better error localisation in error snippets
  • fixed handling of errors containing Go fmt verb syntax
  • fix type signature of flatten extension
  • recover internal panics to informative errors

If elastic/mito#71 is merged before this PR closes, I think it would be worth adding that into this change and bumping to v1.15.0. Now included in this change.

Note that runtime error handling is still not perfect. I will come back to this later. I've looked into this and what I was thinking was happening is happening; the _+_ call is returning an error type and there is no get overload for an error. It looks like the CEL runtime is not decorating/throwing when the _+_ call returns the error, so the next call is what gives error location annotation. There is not anything we can do about this at this level, and the error quality is reasonable. I may take another look at the runtime later.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team labels Jul 17, 2024
@efd6 efd6 self-assigned this Jul 17, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 17, 2024
@efd6
Copy link
Contributor Author

efd6 commented Jul 17, 2024

/test

@efd6 efd6 force-pushed the cel_1_14 branch 3 times, most recently from be65f66 to 0276bc0 Compare July 18, 2024 03:13
@efd6 efd6 marked this pull request as ready for review July 18, 2024 06:19
@efd6 efd6 requested review from a team as code owners July 18, 2024 06:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

This brings error-handling improvements.

* better error localisation in error snippets
* fixed handling of errors containing Go fmt verb syntax
@efd6 efd6 changed the title mod: update elastic/mito to version v1.14.0 mod: update elastic/mito to version v1.15.0 Jul 19, 2024
@efd6 efd6 merged commit 0d2fce7 into elastic:main Jul 23, 2024
120 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants